This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Multiple languages #767
Merged
Multiple languages #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfelton
force-pushed
the
crowdin
branch
7 times, most recently
from
12edea2
to
17f51c0
Compare
mrfelton
force-pushed
the
crowdin
branch
2 times, most recently
from
d9d4a6d
to
2fb1e2e
Compare
|
@JimmyMow I have added an additional commit to this PR which detects a best-fit default currency for the user based on their locale. We default back to |
Merged
mrfelton
force-pushed
the
crowdin
branch
9 times, most recently
from
9cd9dd0
to
a4cdd7b
Compare
Use the locale information in order to select a best fit default currency for the user.
Use `intl.formattedNumber` to display currency values to ensure that currencies are displayed using the formatting rules that match the user's locale.
* New translations en.json (Irish) [ci skip] * New translations en.json (Ukrainian) [ci skip] * New translations en.json (Turkish) [ci skip] * New translations en.json (Swedish) [ci skip] * New translations en.json (Spanish) [ci skip] * New translations en.json (Russian) [ci skip] * New translations en.json (Romanian) [ci skip] * New translations en.json (Portuguese, Brazilian) [ci skip] * New translations en.json (Portuguese) [ci skip] * New translations en.json (Polish) [ci skip] * New translations en.json (Japanese) [ci skip] * New translations en.json (Italian) [ci skip] * New translations en.json (Arabic) [ci skip] * New translations en.json (Hindi) [ci skip] * New translations en.json (Hebrew) [ci skip] * New translations en.json (Greek) [ci skip] * New translations en.json (German) [ci skip] * New translations en.json (French) [ci skip] * New translations en.json (Dutch) [ci skip] * New translations en.json (Danish) [ci skip] * New translations en.json (Czech) [ci skip] * New translations en.json (Croatian) [ci skip] * New translations en.json (Chinese Traditional) [ci skip] * New translations en.json (Chinese Simplified) [ci skip] * New translations en.json (Bulgarian) [ci skip]
|
Tested ACK 5c93cee |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements
i18nsupport in our repo using https://github.com/yahoo/react-intlYou can switch languages in two different ways:
Languagemenu at the top of the screenSettingsmenu within the app.Default local should be detected by the browser. When you change locale, this will be saved as a setting in our settings store and used as the selected language next time you start the app.
Additionally, a best-fit default currency is selected for the user based on their determined country.
I identified quite a lot of strings that were not included in the original extraction so none of the translations are 100% now. Additionally, the structure of the translation files has changed from what we originally uploaded to Crowdin and whilst I have tried where possible to carry over the translations that were submitted to us, it is possible that some did not make it over.
Note: This builds on #754 #755 and #756 - so those should be merged prior to this one.
Motivation and Context:
Support international users.
How Has This Been Tested?
Ran all tests and manually test app.
Screenshots (if appropriate):
Types of changes:
New Feature
Checklist: