fix merkle proof conversion #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
approved these changes
Nov 20, 2022
There was a problem hiding this comment.
ACK 02167b9
Thank you for this remarkable discovery of the source of the bug!
|
Released v0.8.1 of @crisdut can you also pls open a PR against the master branch to ensure the next version wouldn't get the same bug again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
rgb-nodeproduces an incorrect merkle proof anchor when compiled in release mode.This problem occurs because the conversion of the merkle block into a merkle proof was inside the debug_assert method.
Closes:
Related:
rgbdcausesTransitionNotInAnchorRGB-WG/rgb-node#197