Temp change of unreachable for known bug #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
ACK 538417b
I think it is the simplest possible temporary fix, so everything looks good to me.
|
Have you tried to compile IRIS wallet and test how it works in cases which were failing before? I mean can I release this version, wouldn't it break anything downstram? |
|
Yes, we tried and now when the bug occurs the app doesn't stale anymore. So I think it's safe to release this |
|
@zoedberg published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refers to what has been discussed here RGB-WG/rgb-node#208 (comment)
I know that
UnrelatedProofis not the correct error in this case, but trying to change it to something else causes bp-dbc to stop compiling and I don't think we should change everything for a very temporary change. @dr-orlovsky please let me know if I'm missing a simple way to introduce a proper error