Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrictEncoding issue with enum tuple struct field initialization #54

Closed
cryptoquick opened this issue Feb 9, 2022 · 7 comments
Closed
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@cryptoquick
Copy link
Member

When fixing some clippy lints on the descriptor wallet, I ran into an issue here:

Screenshot from 2022-02-09 12-30-55

Docs on the linter rule are here:
https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields

Normally I wouldn't file a feature request just to satisfy a linter, but this might be indicative of some sort of oversight. Feel free to close if we're comfortable with using #![allow(clippy::init_numbered_fields)] in all projects using strict encoding.

@dr-orlovsky dr-orlovsky self-assigned this Feb 19, 2022
@dr-orlovsky dr-orlovsky added bug Something isn't working help wanted Extra attention is needed labels Feb 19, 2022
@dr-orlovsky dr-orlovsky added this to the v0.6.0 milestone Feb 19, 2022
@dr-orlovsky
Copy link
Member

Hm, not sure I understand what specifically linter does not like here and how it can be fixed. Any ideas?

@dr-orlovsky
Copy link
Member

sorry for closing, pressed the wrong button

@cryptoquick
Copy link
Member Author

It looks like this is a problem that might be fixed once 1.59 is released:
https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md#new-lints

I noticed it goes away if the nightly toolchain is used.

@dr-orlovsky
Copy link
Member

1.59 got released. Can we close this issue?

@cryptoquick
Copy link
Member Author

cryptoquick commented Mar 7, 2022

No, it's just that the lint is in stable now. The issue persists. Sorry for confusing the matter, I misspoke earlier.

@dr-orlovsky dr-orlovsky modified the milestones: v0.6.0, v0.7.0 May 24, 2022
@dr-orlovsky dr-orlovsky modified the milestones: v0.7.0, v0.8.0, v0.9.0 Jun 13, 2022
@cryptoquick
Copy link
Member Author

🎉

@dr-orlovsky
Copy link
Member

Thank you for bringing the attention to the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
No open projects
Development

No branches or pull requests

2 participants