Support to Regtest Address

[crisdut]

Details: https://github.com/orgs/LNP-BP/discussions/128

[codecov-commenter]

Codecov Report

Merging #61 (226d268) into master (a403e25) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##           master    #61     +/-   ##
=======================================
- Coverage     0.1%   0.1%   -0.0%     
=======================================
  Files          40     41      +1     
  Lines        3186   3317    +131     
=======================================
  Hits            3      3             
- Misses       3183   3314    +131     

Impacted Files	Coverage Δ
cli/src/command.rs	0.0% <0.0%> (ø)
cli/src/main.rs	6.7% <0.0%> (-3.3%)	⬇️
cli/src/opts.rs	0.0% <0.0%> (ø)
rpc/src/client.rs	0.0% <0.0%> (ø)
rpc/src/error.rs	0.0% <0.0%> (ø)
rpc/src/lib.rs	100.0% <ø> (ø)
rpc/src/listen_addr.rs	0.0% <0.0%> (ø)
rpc/src/messages.rs	0.0% <0.0%> (ø)
rpc/src/service_id.rs	0.0% <0.0%> (ø)
src/automata.rs	0.0% <ø> (ø)
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[dr-orlovsky]

Is it that AddressCompat doesn't support regtest? If not, it should - since it is a part of the address string; and I will look how to update it first.

AddressCompat provides stronger guarantees that the address, once parsed, is supported by the wallet, that is why it is used here

[crisdut]

Is it that AddressCompat doesn't support regtest? If not, it should - since it is a part of the address string; and I will look how to update it first.

AddressCompat provides stronger guarantees that the address, once parsed, is supported by the wallet, that is why it is used here

Hi @dr-orlovsky,

I reverted the change and created a new PR related:

• Add regtest to AddressCompat BP-WG/descriptor-wallet#64

[dr-orlovsky]

Please see my comments in BP-WG/descriptor-wallet#64 (comment)

We need to decide upon that problem first

[dr-orlovsky]

ACK 226d268 as a temporary fix pending #62