Skip to content

Commit

Permalink
Bug fix regarding non-lowercase inputs.
Browse files Browse the repository at this point in the history
  • Loading branch information
agarie committed Jun 4, 2012
1 parent c01e58d commit 733187c
Showing 1 changed file with 18 additions and 7 deletions.
25 changes: 18 additions & 7 deletions src/typecalc.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ TYPECALC.io = (function () {
var team = [];

$.each(pkmn, function(index, value) {
type_1 = value.querySelector("input[name='type-1']").value;
type_2 = value.querySelector("input[name='type-2']").value;
type_1 = value.querySelector("input[name='type-1']").value.toLowerCase();
type_2 = value.querySelector("input[name='type-2']").value.toLowerCase();

team.push([type_1, type_2]);
});
Expand Down Expand Up @@ -151,6 +151,17 @@ TYPECALC.io = (function () {
return tmp;
};

var addEmphasisClassConditionally = function (value, className) {
className = className || 'emphasis';

if (value > 0) {
return "<td class='" + className + "'>" + value + "</td>";
}
else {
return "<td>" + value + "</td>";
}
};

var createReport = function (resistsAndWeaks) {
// Initialize the report parts as jQuery objects.
var report = $("<table>");
Expand Down Expand Up @@ -202,11 +213,11 @@ TYPECALC.io = (function () {
tmp = $("<tr>");

tmp.append("<td>" + TYPES[index] + "</td>");
tmp.append("<td>" + obj.quarterEffect + "</td>");
tmp.append("<td>" + obj.halfEffect + "</td>");
tmp.append("<td>" + obj.noEffect + "</td>");
tmp.append("<td>" + obj.doubleEffect + "</td>");
tmp.append("<td>" + obj.quadEffect + "</td>");
tmp.append(addEmphasisClassConditionally(obj.quarterEffect));
tmp.append(addEmphasisClassConditionally(obj.halfEffect));
tmp.append(addEmphasisClassConditionally(obj.noEffect));
tmp.append(addEmphasisClassConditionally(obj.doubleEffect));
tmp.append(addEmphasisClassConditionally(obj.quadEffect));

reportBody.append(tmp);

Expand Down

0 comments on commit 733187c

Please sign in to comment.