Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variants_found missing in LOVD2 to LOVD3 conversion output #243

Closed
mkroon1 opened this issue Jul 10, 2017 · 0 comments
Closed

variants_found missing in LOVD2 to LOVD3 conversion output #243

mkroon1 opened this issue Jul 10, 2017 · 0 comments
Labels
bug minor
Projects
Milestone 3.0-20
Milestone
3.0 Build 20

Comments

@mkroon1
Copy link
Collaborator

mkroon1 commented Jul 10, 2017

The LOVD3 import file generated by scripts/convert_lovd2.php only contains screenings when there are variants to link to them. However, the field variants_found is omitted and becomes 0 during import, which is false.

Solution is to add a variants_found field to the screenings section in the script's output with a default value of 1.
mkroon1 added a commit that referenced this issue Jul 10, 2017
@mkroon1
Added fix for #243 to changelog.
acbfc12
@mkroon1 mkroon1 mentioned this issue Jul 19, 2017
Merged
@ifokkema ifokkema added this to the 3.0 Build 20 milestone Jul 20, 2017
@ifokkema ifokkema added this to To Be Reviewed in Milestone 3.0-20 Jul 20, 2017
@ifokkema ifokkema moved this from To Be Reviewed to Done in Milestone 3.0-20 Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug minor
Projects
No open projects
Milestone 3.0-20
Done
Milestone
3.0 Build 20
Development

No branches or pull requests
2 participants
@ifokkema @mkroon1