Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable homepage #98

Closed
mkroon1 opened this issue Jul 18, 2016 · 3 comments
Closed

Configurable homepage #98

mkroon1 opened this issue Jul 18, 2016 · 3 comments

Comments

@mkroon1
Copy link
Collaborator

mkroon1 commented Jul 18, 2016

Currently LOVD redirects the user to genes.php when visiting the base URL of the LOVD installation. This is a request to make the default web page configurable (requested by J).

Proposal: let administrator or manager set a custom URL to be the homepage. genes.php would be the value after installation. A relative path would be considered relative to LOVD's ROOT_URL. An absolute URL with protocol and hostname is used as given.

@ifokkema
Copy link
Member

Absolute URLs will not be a good idea. If people want a different start page they can just upload a file to LOVD (that redirects if necessary). It can merely be very harmful in case a manager leaves their PC logged into LOVD and people tinker with the settings. Paths can also not contain ../ or similar. LOVD should carefully check the page that this setting is being set to. I would actually argue it's safer to provide a list of options. If people sometimes really want their own welcoming pages, then they could also just edit the index.php...? How many requests have we received about this?

@mkroon1
Copy link
Collaborator Author

mkroon1 commented Jul 19, 2016

How many requests have we received about this?

Just the one.

@ifokkema ifokkema added this to the 3.0 Build 20 milestone Jun 14, 2017
@ifokkema ifokkema added this to TODO in Milestone 3.0-20 Jun 14, 2017
@mkroon1
Copy link
Collaborator Author

mkroon1 commented Jun 14, 2017

Just decided: we fix the most important use case where there is only one gene in the database. In that case, submitters/curators and visitors (not logged in) will be redirected to genes/SYMBOL from the homepage.

We won't make anything general for selecting arbitrary pages as the default home page.

@mkroon1 mkroon1 moved this from TODO to In Progress in Milestone 3.0-20 Jul 20, 2017
mkroon1 added a commit that referenced this issue Jul 24, 2017
@mkroon1 mkroon1 moved this from In Progress to To Be Reviewed in Milestone 3.0-20 Jul 24, 2017
@ifokkema ifokkema moved this from To Be Reviewed to Done in Milestone 3.0-20 Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants