Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MySQL errors during installation on newer MySQL versions #177

Merged
merged 5 commits into from Jan 31, 2017
Merged

Fix MySQL errors during installation on newer MySQL versions #177

merged 5 commits into from Jan 31, 2017

Conversation

ifokkema
Copy link
Member

Fixed "Invalid default value for 'start_date'" error during LOVD installation.

Fixed "Field 'tissues' doesn't have a default value" error during LOVD installation.

@ifokkema
Fixed "Invalid default value for 'start_date'" error during LOVD inst…
f2694e5 
…allation.

- This occurs on newer MySQL versions that have STRICT_MODE enabled by default as well as NO_ZERO_DATE, which disallows a zero date and returns a fatal error.
- This fix works by removing the NO_ZERO_DATE SQL mode for the session that LOVD runs in.
- Closes #143.
- Closes #173.
@ifokkema
Fixed "Field 'tissues' doesn't have a default value" error during LOV…
ae9f05f 
…D installation.

- This occurs on newer MySQL versions that have STRICT_MODE enabled by default, which disallows NOT NULL TEXT columns not mentioned during an insert.
- This fix works by adding the fields to the insert query, putting in empty strings.
- Closes #143.
@ifokkema ifokkema added this to the 3.0 Build 19 milestone Jan 25, 2017
@ifokkema ifokkema requested a review from mkroon1 January 25, 2017 08:34
@ifokkema
Fixed bug; Transcript couldn't be created with strict mode on.
389df76 
- The remarks TEXT column doesn't have a default value. Now LOVD will insert an empty string.
@ifokkema
Added changelog entry.
6e0d851
@mkroon1 mkroon1 merged commit 8dfe238 into master Jan 31, 2017
@mkroon1 mkroon1 deleted the fix/strict_mysql_errors branch January 31, 2017 14:59
@ifokkema ifokkema moved this from To Be Reviewed to Done in Milestone 3.0-19 Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkroon1 mkroon1 mkroon1 approved these changes

Assignees

@ifokkema ifokkema

@mkroon1 mkroon1

Labels
None yet
Projects
No open projects
Milestone 3.0-19
Done
Milestone
3.0 Build 19
Development

Successfully merging this pull request may close these issues.

Installation failed on ubuntu 16 LOVD won't install with error "Invalid default value for 'start_date'"
2 participants
@ifokkema @mkroon1