Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bvecN types have wrong representation #36

Closed
LPGhatguy opened this issue Oct 17, 2021 · 1 comment · Fixed by #39
Closed

bvecN types have wrong representation #36

LPGhatguy opened this issue Oct 17, 2021 · 1 comment · Fixed by #39
Labels
bug Something isn't working

Comments

@LPGhatguy
Copy link
Owner

GLSL's bools are 32 bits. Rust's are 8 bits. Making a vec of 8 bit bools doesn't make them line up.

Additionally, I don't think bool is fully inhabited, so making it Pod/Zeroable isn't quite right.
@LPGhatguy LPGhatguy added the bug Something isn't working label Oct 17, 2021
LPGhatguy added a commit that referenced this issue Oct 17, 2021
@LPGhatguy
Disable bool vectors for now, see #36.
07da2d9
@ElectronicRU
Copy link
Contributor

Onto it, with work done for arrays should be easy-ish.

This was referenced Nov 7, 2021
Closed
Merged
leod pushed a commit to leod/crevice that referenced this issue Jun 3, 2023
@LPGhatguy
Disable bool vectors for now, see LPGhatguy#36.
1b241ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bool vectors! ElectronicRU/crevice
Implement bool vectors in a GLSL way. ElectronicRU/crevice
2 participants
@ElectronicRU @LPGhatguy