Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full FR translation for modules #192

Merged
merged 4 commits into from Oct 29, 2020
Merged

Full FR translation for modules #192

merged 4 commits into from Oct 29, 2020

Conversation

mattnounet
Copy link
Contributor

No description provided.

jxn-30
jxn-30 requested changes Oct 29, 2020
View reviewed changes
Copy link
Member

@jxn-30 jxn-30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me except for the one comment currently.

src/modules/extendedBuilding/i18n/fr_FR.root..json Outdated Show resolved Hide resolved
@jxn-30 jxn-30 self-assigned this Oct 29, 2020
Suchty112
Suchty112 reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@Suchty112 Suchty112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are now the mistakes I have found. These are the "default" tabs according to the missionwindow

src/modules/extendedCallWindow/i18n/fr_FR.js Outdated Show resolved Hide resolved
src/modules/extendedCallWindow/i18n/fr_FR.js Outdated Show resolved Hide resolved
src/modules/extendedCallWindow/i18n/fr_FR.js Outdated Show resolved Hide resolved
@Suchty112 Suchty112 requested a review from jxn-30 October 29, 2020 13:20
@Suchty112
Copy link
Member

And if you are doing translations again.
in the main fr_FR file
only_alliance_missions: [57, 74],

Suchty112
Suchty112 reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@Suchty112 Suchty112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the fix for the memberlistroles ^^

src/modules/asyncButtons/i18n/fr_FR.json Outdated Show resolved Hide resolved
src/modules/asyncButtons/i18n/fr_FR.json Outdated Show resolved Hide resolved
src/modules/asyncButtons/i18n/fr_FR.json Outdated Show resolved Hide resolved
@Suchty112 Suchty112 requested review from jxn-30 and removed request for jxn-30 October 29, 2020 14:56
@Suchty112 Suchty112 merged commit 6e05a8f into LSS-Manager:dev Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Suchty112 Suchty112 Suchty112 approved these changes

@jxn-30 jxn-30 jxn-30 approved these changes

@Ron31 Ron31 Awaiting requested review from Ron31

Assignees

@jxn-30 jxn-30

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattnounet @Suchty112 @jxn-30