Numpy 1.24 compatibility

[hsinfan1996]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 3751636306

• 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.003%) to 97.528%

---

Totals
Change from base Build 3734529097:	0.003%
Covered Lines:	4852
Relevant Lines:	4975

---

💛 - Coveralls

[nikfilippas]

Ok, good. In core.py, I'd personally get rid of the extra check for the numpy integer and floating types, particularly as those are generic superclasses.

[hsinfan1996]

Ok, good. In core.py, I'd personally get rid of the extra check for the numpy integer and floating types, particularly as those are generic superclasses.

isinstance(np.float(1.), np.floating) will evaluate to False, because np.float is identical to python float, which is not part of np.floating. Same problem with np.int and int.

[nikfilippas]

isinstance(np.float(1.), np.floating) will evaluate to False, because np.float is identical to python float, which is not part of np.floating. Same problem with np.int and int.

As does isinstance(1., np.floating). AFAIK numpy's floating is a generic superclass which is only there for some lower-level stuff. We can't create instances of np.floating so the check isinstance(v, np.floating) that was there before is a bug.
Also, the class is so generic I'd argue it is akin to checking if something is an instance of object.

[hsinfan1996]

isinstance(np.float(1.), np.floating) will evaluate to False, because np.float is identical to python float, which is not part of np.floating. Same problem with np.int and int.

As does isinstance(1., np.floating). AFAIK numpy's floating is a generic superclass which is only there for some lower-level stuff. We can't create instances of np.floating so the check isinstance(v, np.floating) that was there before is a bug. Also, the class is so generic I'd argue it is akin to checking if something is an instance of object.

Oh I see what you meant.

[hsinfan1996]

Just did some tests
isinstance(np.float64(1.), float) evaluates to True
isinstance(np.float32(1.), float) evaluates to False
isinstance(np.float32(1.), float) evaluates to False
isinstance(np.float32(1.), np.floating) evaluates to True
Are those what we expected?

[nikfilippas]

Just did some tests
isinstance(np.float64(1.), float) evaluates to True
isinstance(np.float32(1.), float) evaluates to False
isinstance(np.float32(1.), float) evaluates to False
isinstance(np.float32(1.), np.floating) evaluates to True
Are those what we expected?

Yes, when writing the yaml file we essentially check the type of the arguments passed in ccl.Cosmology. They will be ints, floats, lists, dicts, or strings. By default, the built-in float and int types match your computer's architecture, so by the output I can tell you work on a 64-bit machine. The rest is just details. And we don't want to involve the np.floating and np.integer superclasses I think, it will just complicate things more.