Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTD fix #1032

Merged
merged 11 commits into from
Mar 15, 2023
Merged

RTD fix #1032

merged 11 commits into from
Mar 15, 2023

Conversation

damonge
Copy link
Collaborator

@damonge damonge commented Mar 15, 2023

Fixes readthedocs issue triggered by new functionality.
I've tested that this runs as it should on readthedocs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4428137298

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.74%
Totals Coverage Status
Change from base Build 4426780279: 0.0%
Covered Lines: 5449
Relevant Lines: 5575
💛 - Coveralls

nikfilippas
nikfilippas reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@nikfilippas nikfilippas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that it works, but have a quick look at the comments.

readthedocs/requirements.txt Show resolved Hide resolved
.readthedocs.yaml Show resolved Hide resolved
@damonge
Copy link
Collaborator Author

damonge commented Mar 15, 2023

The generated docs are here https://ccl.readthedocs.io/en/rtd_fix_cached_property/

nikfilippas
nikfilippas approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@nikfilippas nikfilippas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damonge damonge merged commit 95b47e3 into master Mar 15, 2023
@damonge damonge deleted the rtd_fix_cached_property branch March 15, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikfilippas nikfilippas nikfilippas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@damonge @coveralls @nikfilippas