Enhanced FFTLog options in HaloProfile
#1061
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not to be reviewed until all existing functionality has been ported to v3. There is new science implementations that take priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that is currently implemented in an odd way is that if users want to pass their own values to FFTLog when they create a
HaloProfile, they have to instantiate it first, and then change the values viaupdate_precision_fftlog. This is awkward - we used to do that for theCosmologyobject too, but we have long deprecated that.This PR enables passing the FFTLog parameters directly into the halo profile constructors.
The parameters can be passed as keyword arguments, and with calls to
superthat we are doing either way, they are eventually handled byHaloProfilebase.