-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightweight docs revamp for v2.last #1082
Conversation
Pull Request Test Coverage Report for Build 5005392826
💛 - Coveralls |
pyccl/pk2d.py
Outdated
@@ -146,36 +152,37 @@ def __init__(self, *, a_arr=None, lk_arr=None, pk_arr=None, | |||
|
|||
@classmethod | |||
def from_function(cls, pkfunc, *, is_logp=True, | |||
spline_params=spline_params, | |||
spline_par=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do that, it will be super confusing for people to refer to it with 2 different names.
What you need to do is remove spline_params
from the imports at the top, and replace the lines in the function with:
if spline_params is None:
from . import spline_params
Much neater, and you get to keep the same name. We use params
to refer to parameters everywhere in CCL. Let's be consistent. (See the docs_v3 PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got finally through it. I have added quite a few of comments/questions. None important. Most of them typos or things that I don't see clearly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested.
Thanks again @carlosggarcia . Back to you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The docs can be viewed here: https://ccl.readthedocs.io/en/docs_v2last_lite/