Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 preparation #1087

Merged
merged 19 commits into from
Jun 7, 2023
Merged

v3 preparation #1087

merged 19 commits into from
Jun 7, 2023

Conversation

damonge
Copy link
Collaborator

@damonge damonge commented May 19, 2023

No description provided.

@coveralls
Copy link

coveralls commented May 19, 2023 •
edited

Pull Request Test Coverage Report for Build 5193609277

  • 83 of 83 (100.0%) changed or added relevant lines in 36 files are covered.
  • 36 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.4%) to 97.543%
Files with Coverage Reduction New Missed Lines %
pyccl/halos/massdef.py 1 99.23%
pyccl/_core/schema.py 2 95.95%
pyccl/halos/profiles/profile_base.py 2 98.62%
pyccl/nl_pt/tracers.py 13 83.52%
pyccl/_core/deprecations.py 18 21.43%
Totals Coverage Status
Change from base Build 5022976068: 0.4%
Covered Lines: 5122
Relevant Lines: 5251
💛 - Coveralls

carlosggarcia
carlosggarcia requested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@carlosggarcia carlosggarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments

pyccl/__init__.py Show resolved Hide resolved
pyccl/boltzmann.py Show resolved Hide resolved
pyccl/halos/halo_model.py Show resolved Hide resolved
pyccl/halos/hmfunc/watson13.py Show resolved Hide resolved
pyccl/halos/massdef.py Outdated Show resolved Hide resolved
carlosggarcia
carlosggarcia approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@carlosggarcia carlosggarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damonge damonge marked this pull request as ready for review June 7, 2023 07:39
@damonge
Copy link
Collaborator Author

damonge commented Jun 7, 2023

Thanks for this @carlosggarcia !
Just to clarify, won't press merge until we've released the current version of master (the last v2 version). Will do so later today. Just leaving this message here in case anyone feels the urge to press "merge" ;-)

@damonge damonge merged commit d421ca0 into master Jun 7, 2023
4 checks passed
@damonge damonge deleted the v3_remove_depr branch June 7, 2023 11:05
@paulrogozenski paulrogozenski mentioned this pull request Jul 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosggarcia carlosggarcia carlosggarcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@damonge @coveralls @carlosggarcia