Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projected Einasto profile from numerical integration #1093

Merged
merged 14 commits into from
Jul 17, 2023
Merged

Projected Einasto profile from numerical integration #1093

merged 14 commits into from
Jul 17, 2023

Conversation

hsinfan1996
Copy link
Contributor

@hsinfan1996 hsinfan1996 commented Jun 29, 2023 •
edited

Using FFTLog is faster, but using numerical integration is more accurate at large radius.

@hsinfan1996 hsinfan1996 changed the title Add Einasto projected profile from integration Projected Einasto profile from integration Jun 29, 2023
@hsinfan1996 hsinfan1996 changed the title Projected Einasto profile from integration Projected Einasto profile from numerical integration Jun 29, 2023
@coveralls
Copy link

coveralls commented Jun 29, 2023 •
edited

Pull Request Test Coverage Report for Build 5573225588

  • 24 of 24 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 97.439%
Totals Coverage Status
Change from base Build 5553290862: 0.01%
Covered Lines: 5669
Relevant Lines: 5818
💛 - Coveralls

@hsinfan1996 hsinfan1996 requested review from nikfilippas and damonge and removed request for nikfilippas June 29, 2023 17:39
@hsinfan1996 hsinfan1996 marked this pull request as draft June 30, 2023 14:20
@hsinfan1996 hsinfan1996 marked this pull request as ready for review June 30, 2023 15:22
damonge
damonge reviewed Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @hsinfan1996 . A few comments below.

pyccl/halos/profiles/einasto.py Show resolved Hide resolved
pyccl/tests/test_profiles.py Show resolved Hide resolved
pyccl/halos/profiles/einasto.py Outdated Show resolved Hide resolved
@hsinfan1996 hsinfan1996 requested a review from damonge July 15, 2023 14:00
damonge
damonge requested changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more things and we're done.

pyccl/halos/profiles/einasto.py Outdated Show resolved Hide resolved
pyccl/tests/test_profiles.py Show resolved Hide resolved
@hsinfan1996 hsinfan1996 requested a review from damonge July 17, 2023 08:58
damonge
damonge approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsinfan1996
Copy link
Contributor Author

Thank you.

@hsinfan1996 hsinfan1996 merged commit 86125b0 into master Jul 17, 2023
7 checks passed
@hsinfan1996 hsinfan1996 deleted the einasto_proj_integrate branch July 17, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonge damonge damonge approved these changes

@nikfilippas nikfilippas Awaiting requested review from nikfilippas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsinfan1996 @coveralls @damonge