LPT NL PT #1097
Merged
LPT NL PT #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I removed the heft_aemulus import, since I think it was a leftover and I wanted to see if tests pass. Bring it back if it was intentional! |
Closed
Pull Request Test Coverage Report for Build 5519362457
💛 - Coveralls |
damonge
approved these changes
Jul 12, 2023
|
|
||
|
|
||
| @pytest.mark.parametrize('kind', ['m:m', 'm:b2', 'm:b3nl', 'm:bs', | ||
| 'b1:b3nl', 'b3nl:b3nl', 'b3nl:bk2']) |
There was a problem hiding this comment.
Question: you only added these because testing all combinations takes a bit too long, right?
There was a problem hiding this comment.
I think that's OK, btw, just wanted to check.
There was a problem hiding this comment.
Yeah that's the thing driving the coverage. The problem is the 1, delta_L split in LPT. Because of that you can't isolate the bias terms as you can in EPT. I think these are the only ones that work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements LPT in the nl_pt modules. This mostly follows the implementation for EPT, but I have included a bunch of additional terms for b_nabla2, and also the template function is a bit different due to the presence of the 1 and delta_L terms. I can change that though if we want full consistency.