Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bocquet 2020 mass function emulator #1115

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Bocquet 2020 mass function emulator #1115

merged 8 commits into from
Jul 31, 2023

Conversation

damonge
Copy link
Collaborator

@damonge damonge commented Jul 27, 2023

Closes #235

@coveralls
Copy link

coveralls commented Jul 27, 2023 •
edited

Pull Request Test Coverage Report for Build 5717299029

  • 41 of 41 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.452%
Totals Coverage Status
Change from base Build 5694401474: 0.02%
Covered Lines: 5776
Relevant Lines: 5927
💛 - Coveralls

@damonge damonge marked this pull request as ready for review July 27, 2023 15:33
carlosggarcia
carlosggarcia requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@carlosggarcia carlosggarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

benchmarks/test_bocquet20_hmf.py Show resolved Hide resolved
benchmarks/test_bocquet20_hmf.py Show resolved Hide resolved
pyccl/tests/test_hmfunc.py Outdated Show resolved Hide resolved
@damonge
Copy link
Collaborator Author

damonge commented Jul 31, 2023

Thanks a lot @carlosggarcia ! Back to you.

carlosggarcia
carlosggarcia approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@carlosggarcia carlosggarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damonge damonge merged commit fda2e0c into master Jul 31, 2023
4 checks passed
@damonge damonge deleted the bocquet20_emulator branch July 31, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosggarcia carlosggarcia carlosggarcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add emulators for cluster mass function
3 participants
@damonge @coveralls @carlosggarcia