Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trispectrum docstring fix #1168

Merged
merged 2 commits into from May 1, 2024
Merged

Trispectrum docstring fix #1168

merged 2 commits into from May 1, 2024

Conversation

damonge
Copy link
Collaborator

@damonge damonge commented Mar 19, 2024

Closes #1153

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8350704788

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.484%

Totals Coverage Status
Change from base Build 8206502277: 0.0%
Covered Lines: 6547
Relevant Lines: 6716

💛 - Coveralls

@damonge
Copy link
Collaborator Author

damonge commented Mar 20, 2024

The new docs can be seen in this temporary rtd version: https://ccl.readthedocs.io/en/doc_trispectrum_fix/api/pyccl.halos.pk_4pt.html

Copy link
Collaborator

@elisachisari elisachisari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the issues I had identified in #1153 are now gone, so happy to merge this.

@damonge damonge merged commit 8a1ecb6 into master May 1, 2024
4 checks passed
@damonge damonge deleted the doc_trispectrum_fix branch May 1, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trispectrum docs have some small bugs
3 participants