Analytic Einasto and Hernquist normalization

[hsinfan1996]

Some functions in src/ccl_haloprofile.c and pyccl/ccl_haloprofile.i are not needed anymore, but I did not touch them.

[coveralls]

Pull Request Test Coverage Report for Build 2709235802

• 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.002%) to 97.1%

---

Totals
Change from base Build 2669526928:	-0.002%
Covered Lines:	4553
Relevant Lines:	4689

---

💛 - Coveralls

[damonge]

Thanks a lot @hsinfan1996 . Can you check how much faster (or slower) it is to call the gamma functions than computing the normalisation numerically?

[hsinfan1996]

Thanks a lot @hsinfan1996 . Can you check how much faster (or slower) it is to call the gamma functions than computing the normalisation numerically?

1. If M, R_s, R_M and alpha are floats, ~9 times faster.
2. If M, R_s, R_M and alpha are arrays with each having only one element, ~1.2 times faster.
3. If M, R_s, R_M and alpha are arrays with each having 100 elements, ~7 times faster.

[damonge]

OK, awesome, in that case feel free to remove all traces of the old functions in src/ccl_haloprofile.c and pyccl/ccl_haloprofile.i

[hsinfan1996]

Coveralls is down. Could not submit results when the check for macos finished.

[damonge]

Ignore coveralls. Coverage went down because you reduced the number of lines in the code, I bet.

[damonge]

Thanks a lot! It feels great to get rid of unnecessary C code!
Just one comment.

[damonge]

It seems coveralls is undergoing some maintenance. I'm sure it's irrelevant, but let's wait for tomorrow before merging (pressing the red merge button makes my brain scream a bit)

[hsinfan1996]

It seems coveralls is undergoing some maintenance. I'm sure it's irrelevant, but let's wait for tomorrow before merging (pressing the red merge button makes my brain scream a bit)

Sure. I want it to pass all the checks too. I will re-run the jobs when Coveralls is stable.

[damonge]

LGTM!