Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to profiles on squeezed shapes and fix Hernquist _fourier_analytic #966

Merged
merged 5 commits into from
Aug 3, 2022
Merged

Add test to profiles on squeezed shapes and fix Hernquist _fourier_analytic #966

merged 5 commits into from
Aug 3, 2022

Conversation

hsinfan1996
Copy link
Contributor

No description provided.

@hsinfan1996 hsinfan1996 changed the title Add test on profile squeezed shapes and fix Hernquist _fourier_analytic Add test to profiles on squeezed shapes and fix Hernquist _fourier_analytic Aug 3, 2022
@hsinfan1996 hsinfan1996 linked an issue Aug 3, 2022 that may be closed by this pull request
Hernquist _fourier_analytic does not squeeze results to the correct shapes in all cases #965
Closed
@hsinfan1996
Copy link
Contributor Author

@damonge New version of flake8 reports new errors that were not there in version 4.0.1. Should we fix them in a separate PR?

@damonge
Copy link
Collaborator

damonge commented Aug 3, 2022

Yeah, I noticed that in a different repo. Let me fix them in another PR and I'll ask you to review.

@damonge
Copy link
Collaborator

damonge commented Aug 3, 2022

Just asked you to review #967

@coveralls
Copy link

coveralls commented Aug 3, 2022 •
edited

Pull Request Test Coverage Report for Build 2789860888

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 97.43%
Totals Coverage Status
Change from base Build 2789198975: 0.1%
Covered Lines: 4776
Relevant Lines: 4902
💛 - Coveralls

damonge
damonge approved these changes Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsinfan1996
Copy link
Contributor Author

LGTM

Thank you.

@hsinfan1996
Copy link
Contributor Author

@damonge Should I SQUASH and merge now?

@damonge
Copy link
Collaborator

damonge commented Aug 3, 2022

Yep, just press the green button ;-)

@hsinfan1996 hsinfan1996 merged commit d99b2cf into master Aug 3, 2022
@damonge damonge deleted the test_profiles_squeeze branch August 3, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonge damonge damonge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hernquist _fourier_analytic does not squeeze results to the correct shapes in all cases
3 participants
@hsinfan1996 @damonge @coveralls