Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useful error for transfer functions with non-monotonic scale factors #971

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

damonge
Copy link
Collaborator

@damonge damonge commented Aug 5, 2022

Closes #823

This is actually documented, but at least now we'll throw a more useful error.

@coveralls
Copy link

coveralls commented Aug 5, 2022

Pull Request Test Coverage Report for Build 2804924260

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 97.503%

Totals Coverage Status
Change from base Build 2796687136: 0.001%
Covered Lines: 4842
Relevant Lines: 4966

💛 - Coveralls

Copy link
Contributor

@nikfilippas nikfilippas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@damonge damonge merged commit aad5346 into master Aug 5, 2022
@damonge damonge deleted the fix_823 branch August 5, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic Cell integration failure with generalized tracers
3 participants