Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to make einasto alpha a free parameter #987

Merged
merged 5 commits into from
Aug 24, 2022
Merged

Add option to make einasto alpha a free parameter #987

merged 5 commits into from
Aug 24, 2022

Conversation

hsinfan1996
Copy link
Contributor

The Einasto alpha parameter can now be assigned by users.

@damonge
Copy link
Collaborator

damonge commented Aug 24, 2022

Great. Can we give it an update_parameters method, the same way we do e.g. here?

@hsinfan1996
Copy link
Contributor Author

Great. Can we give it an update_parameters method, the same way we do e.g. here?

Sure.

@coveralls
Copy link

coveralls commented Aug 24, 2022 •
edited

Pull Request Test Coverage Report for Build 2917802926

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 97.502%
Totals Coverage Status
Change from base Build 2890164524: 0.004%
Covered Lines: 4840
Relevant Lines: 4964
💛 - Coveralls

@hsinfan1996 hsinfan1996 linked an issue Aug 24, 2022 that may be closed by this pull request
Add an option to make Einasto alpha a free parameter #986
Closed
damonge
damonge approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsinfan1996 hsinfan1996 merged commit 7b44b1e into master Aug 24, 2022
@hsinfan1996 hsinfan1996 deleted the free_einasto_alpha branch August 24, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damonge damonge damonge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to make Einasto alpha a free parameter
3 participants
@hsinfan1996 @damonge @coveralls