Skip to content

Commit

Permalink
eliminate unnecessary tests
Browse files Browse the repository at this point in the history
  • Loading branch information
JoanneBogart committed May 29, 2024
1 parent 50bdea6 commit 839fbc2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 30 deletions.
13 changes: 0 additions & 13 deletions tests/end_to_end_tests/test_database.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,3 @@ def test_query_all():
results = datareg.Query.find_datasets()

assert results is not None


def test_db_version():
"""
Test if db version is what we think it should be.
CI makes a fresh database, hence actual db versions should match
versions to be used when new db is created.
Add a line so github uses this code (I hope)
"""
actual_major, actual_minor, actual_patch = datareg.Query.get_db_versioning()
assert actual_major == 2, "db major version doesn't match expected"
assert actual_minor == 3, "db minor version doesn't match expected"
assert actual_patch == 0, "db patch version doesn't match expected"
17 changes: 0 additions & 17 deletions tests/end_to_end_tests/test_database_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,6 @@
from database_test_utils import *


def test_db_version(dummy_file):
"""
Test the `Query.get_db_versioning()` function.
CI makes a fresh database, hence actual db versions should match
versions to be used when new db is created
"""

# Establish connection to database
tmp_src_dir, tmp_root_dir = dummy_file
datareg = DataRegistry(root_dir=str(tmp_root_dir), schema=SCHEMA_VERSION)

actual_major, actual_minor, actual_patch = datareg.Query.get_db_versioning()
assert actual_major == 2, "db major version doesn't match expected"
assert actual_minor == 3, "db minor version doesn't match expected"
assert actual_patch == 0, "db patch version doesn't match expected"


def test_get_dataset_absolute_path(dummy_file):
"""
Test the generation of the full absolute path of a dataset using the
Expand Down

0 comments on commit 839fbc2

Please sign in to comment.