Ellipticity validation #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the update @msimet - CC @dkorytov @evevkovacs - based on the updated DESCQA test Melanie posted above, it looks like the ellipticity model upgrade was applied to v4.4 and v4.5, but not v4.5_rescale. |
|
I'd be happy to make that change if you think it's useful! |
|
@msimet Yes, in particular because the config files will included in the web interface, it will make it easier for users to find out what validation criteria are used. Thank you for making that change! |
|
I think I have implemented these changes--you can view the new outputs here. |
yymao
reviewed
Jun 2, 2018
descqa/EllipticityDistribution.py
Outdated
| #check overall ellipticity distribution | ||
| global_N = np.sum(np.sum(N_array, axis=1), axis=0) | ||
| number_passed, percentiles = self.validate_percentiles(global_N) | ||
| print("Percentiles for global distribution are:".format(morphology)+', '.join([" {:.3f} ({})".format(p, v) for p,v in zip(percentiles, self.validation_percentiles['percentiles'])])) |
There was a problem hiding this comment.
the first .format is not actually being used.
There was a problem hiding this comment.
Okay, I think this is fixed now...
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code contains the validation criteria for the ellipticity distribution test. A run of this test on the v4.* catalogs can be found here. Everything passes except for the late-type galaxies in proto-dc2_v4.5_rescale, where the 10th percentile is a little high (0.41 instead of <=0.4). I'm not sure that's actually important--I've left if for now so more knowledgeable people can advise me if that's expected or not. It would probably be okay to adjust that criterion if we needed to, however.
The actual validation criteria used here are:
This is tested for all morphologies separately and for the catalog as a whole; the returned float value is the total number of failed criteria. The criteria are currently hard-coded but the percentiles could be moved to config files if desired.