Modifications to run catalogs with or without agn contributions #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yymao travis checks passed. Please review, thanks! |
yymao
requested changes
Aug 9, 2019
|
@yymao I think the test is now ready and the plot title is improved. Please review. |
yymao
approved these changes
Aug 10, 2019
There was a problem hiding this comment.
Thanks, @evevkovacs. I went ahead to fix some space issues. Once the CI test passes you can merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color distribution test required minor changes to be able to run on the new AGN catalog. Added a flag to select magnitudes with no agn contributions. Added lsst magnitudes as an option in case SDSS or DES magnitudes are unavailable. If LSST magnitudes used, plot title indicates this. Test results are here. Test results for default case with AGN magnitudes included are here