Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGN number-density tests #178

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

AGN number-density tests #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6877137
Initial commit for AGN number-density tests
evevkovacs Aug 30, 2019
ec9f6f2
Fix travis issues
evevkovacs Aug 30, 2019
2374aa7
More travis issues fixed
evevkovacs Aug 30, 2019
0c225bc
Updates to implement agn-fraction choices
evevkovacs Sep 9, 2019
b368d20
Remove extra print statement
evevkovacs Sep 9, 2019
55a563d
Merge branch 'master' into agn_tests
evevkovacs Sep 18, 2019
103aad5
Added duty-cycle option
evevkovacs Sep 18, 2019
916e322
Merge branch 'agn_tests' of github.com:LSSTDESC/descqa into agn_tests
evevkovacs Sep 18, 2019
bc11581
Delete AGN_NumberDensity_SDSSg_frac.01.yaml
evevkovacs Sep 18, 2019
d386940
Delete AGN_NumberDensity_SDSSi_frac.01.yaml
evevkovacs Sep 18, 2019
d3bff1b
Merge branch 'master' into agn_tests
evevkovacs Sep 18, 2019
6846548
Minor change to adjust for not using extinction as default in reader
evevkovacs Sep 21, 2019
6b0b8fe
Merge branch 'agn_tests' of github.com:LSSTDESC/descqa into agn_tests
evevkovacs Sep 21, 2019
792c83f
Merge branch 'master' of https://github.com/LSSTDESC/descqa into agn_…
evevkovacs Jan 30, 2020
35b4cef
Cosmetic changes for DC2 paper plots
evevkovacs Jan 31, 2020
e70589a
Merge branch 'master' of https://github.com/LSSTDESC/descqa into agn_…
evevkovacs Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
414 changes: 414 additions & 0 deletions descqa/AGN_NumberDensities.py
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions descqa/configs/AGN_NumberDensity_SDSSg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
subclass_name: AGN_NumberDensities.AGN_NumberDensity
band: g
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the number density agreement for the three SDSS_g* tests so poor? I'm looking at plots like
Nagn_vs_mag_g for the SDSS_g test on the cosmoDC2_v1.1.4_small_combined_agn catalog. I'll try running it for a bigger catalog; maybe the small one is missing the brightest quasars? Also, is there a list of catalogs this test is meant to run for and does DESCQA let you specify it anywhere?

rest_frame_band: i
Mag_lim: -22.5
z_lim: [0.3, 2.2]
observation: 'SDSS'
validation_range: [15.5, 19.]
agn_flux_fraction: 0.
duty_cycle_on: true
no_agn_extinction: true
included_by_default: true
description: 'Plot N and N(<mag) distributions for selected magnitude bound and redshift range in specified band and compare with SDSS data from Richards 2006'
15 changes: 15 additions & 0 deletions descqa/configs/AGN_NumberDensity_SDSSg_fig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
subclass_name: AGN_NumberDensities.AGN_NumberDensity
band: g
rest_frame_band: i
Mag_lim: -22.5
z_lim: [0.3, 2.2]
observation: 'SDSS'
validation_range: [15.5, 19.]
agn_flux_fraction: 0.
duty_cycle_on: true
no_agn_extinction: true
cumulative_only: true
truncate_cat_name: true
included_by_default: false
no_legend_title: true
description: 'Plot N and N(<mag) distributions for selected magnitude bound and redshift range in specified band and compare with SDSS data from Richards 2006'
12 changes: 12 additions & 0 deletions descqa/configs/AGN_NumberDensity_SDSSg_frac.5.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
subclass_name: AGN_NumberDensities.AGN_NumberDensity
band: g
rest_frame_band: i
Mag_lim: -22.5
z_lim: [0.3, 2.2]
observation: 'SDSS'
validation_range: [15.5, 19.]
agn_flux_fraction: 0.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What motivated the minimum flux fraction of 0.5 here (and also in SDSSi_frac.5)? Is this supposed to be a comparison with the duty cycle model?

no_agn_extinction: true
duty_cycle_on: false
included_by_default: false
description: 'Plot N and N(<mag) distributions for selected magnitude bound and redshift range in specified band and compare with SDSS data from Richards 2006'
12 changes: 12 additions & 0 deletions descqa/configs/AGN_NumberDensity_SDSSi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
subclass_name: AGN_NumberDensities.AGN_NumberDensity
band: i
rest_frame_band: i
Mag_lim: -22.5
z_lim: [0.3, 2.2]
observation: 'SDSS'
validation_range: [16., 19.5]
agn_flux_fraction: 0.
duty_cycle_on: true
no_agn_extinction: true
included_by_default: true
description: 'Plot N and N(<mag) distributions for selected magnitude bound and redshift range in specified band and compare with SDSS data from Richards 2006'
15 changes: 15 additions & 0 deletions descqa/configs/AGN_NumberDensity_SDSSi_fig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
subclass_name: AGN_NumberDensities.AGN_NumberDensity
band: i
rest_frame_band: i
Mag_lim: -22.5
z_lim: [0.3, 2.2]
observation: 'SDSS'
validation_range: [16., 19.5]
agn_flux_fraction: 0.
duty_cycle_on: true
no_agn_extinction: true
cumulative_only: true
truncate_cat_name: true
no_legend_title: true
included_by_default: false
description: 'Plot N and N(<mag) distributions for selected magnitude bound and redshift range in specified band and compare with SDSS data from Richards 2006'
12 changes: 12 additions & 0 deletions descqa/configs/AGN_NumberDensity_SDSSi_frac.5.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
subclass_name: AGN_NumberDensities.AGN_NumberDensity
band: i
rest_frame_band: i
Mag_lim: -22.5
z_lim: [0.3, 2.2]
observation: 'SDSS'
validation_range: [15.5, 19.]
agn_flux_fraction: 0.5
no_agn_extinction: true
duty_cycle_on: false
included_by_default: false
description: 'Plot N and N(<mag) distributions for selected magnitude bound and redshift range in specified band and compare with SDSS data from Richards 2006'
26 changes: 26 additions & 0 deletions descqa/data/AGNdata/SDSS/richards_2006_table2.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# RICHARDS ET AL. 2006_AJ_131_2766
# Differential counts for g band with 0.4 < z < 2.2, M_g < 22.5, N per 0.25 mag deg^-2
# Differential counts for i band with 0.3 < z < 2.2, M_i < 22.5, N per 0.25 mag deg^-2
# Cumulative number counts N(<x) in units of deg^-2 for 0.3 < z < 2.2
# Table differs from published version; i-band columns moved up by 1 row as instructed by Gordon Richards
M N_g dN_g N(<g) dN(<g) N_Q N_i dN_i N(<i) dN(<i) N_Q
15.475 0.00 0.00 0.00 0.00 2 0.00 0.00 0.00 0.00 3
15.725 0.00 0.00 0.00 0.00 3 0.00 0.00 0.00 0.00 2
15.975 0.00 0.00 0.01 0.00 4 0.01 0.00 0.02 0.00 10
16.225 0.01 0.00 0.01 0.00 11 0.01 0.00 0.02 0.00 12
16.475 0.01 0.00 0.02 0.00 10 0.01 0.00 0.03 0.00 23
16.725 0.02 0.00 0.04 0.00 32 0.04 0.01 0.08 0.01 67
16.975 0.06 0.01 0.10 0.01 85 0.07 0.01 0.15 0.01 107
17.225 0.08 0.01 0.17 0.01 117 0.11 0.01 0.26 0.01 174
17.475 0.12 0.01 0.29 0.01 190 0.21 0.01 0.47 0.01 327
17.725 0.23 0.01 0.53 0.01 357 0.33 0.01 0.80 0.01 511
17.975 0.31 0.01 0.83 0.01 472 0.55 0.02 1.35 0.02 849
18.225 0.56 0.02 1.40 0.02 868 0.82 0.02 2.17 0.02 1257
18.475 0.78 0.02 2.18 0.02 1202 1.25 0.03 3.42 0.03 1923
18.725 1.19 0.03 3.37 0.03 1839 1.86 0.04 5.28 0.03 2870
18.975 1.70 0.03 5.07 0.03 2620 2.62 0.04 7.90 0.04 4028
19.225 1.61 0.03 6.68 0.03 2484 ... ... ... ... 900
19.475 0.56 0.02 7.24 0.02 855 ... ... ... ... 216
19.725 0.13 0.01 7.37 0.01 206 ... ... ... ... 55
19.975 0.03 0.01 7.41 0.00 53 ... ... ... ... 20
20.225 0.01 0.00 7.42 0.00 19 ... ... ... ... ...
25 changes: 25 additions & 0 deletions descqa/data/AGNdata/SDSS/richards_2006_table2.dat.original
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# RICHARDS ET AL. 2006_AJ_131_2766
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if the extension of this file goes like .original? It does seem like it's not used...

# Differential counts for g band with 0.4 < z < 2.2, M_g < 22.5, N per 0.25 mag deg^-2
# Differential counts for i band with 0.3 < z < 2.2, M_i < 22.5, N per 0.25 mag deg^-2
# Cumulative number counts N(<x) in units of deg^-2 for 0.3 < z < 2.2
M N_g dN_g N(<g) dN(<g) N_Q N_i dN_i N(<i) dN(<i) N_Q
15.475 0.00 0.00 0.00 0.00 2 0.00 0.00 0.00 0.00 1
15.725 0.00 0.00 0.00 0.00 3 0.00 0.00 0.00 0.00 3
15.975 0.00 0.00 0.01 0.00 4 0.00 0.00 0.00 0.00 2
16.225 0.01 0.00 0.01 0.00 11 0.01 0.00 0.01 0.00 10
16.475 0.01 0.00 0.02 0.00 10 0.01 0.00 0.02 0.00 12
16.725 0.02 0.00 0.04 0.00 32 0.01 0.00 0.03 0.00 23
16.975 0.06 0.01 0.10 0.01 85 0.04 0.01 0.08 0.01 67
17.225 0.08 0.01 0.17 0.01 117 0.07 0.01 0.15 0.01 107
17.475 0.12 0.01 0.29 0.01 190 0.11 0.01 0.26 0.01 174
17.725 0.23 0.01 0.53 0.01 357 0.21 0.01 0.47 0.01 327
17.975 0.31 0.01 0.83 0.01 472 0.33 0.01 0.80 0.01 511
18.225 0.56 0.02 1.40 0.02 868 0.55 0.02 1.35 0.02 849
18.475 0.78 0.02 2.18 0.02 1202 0.82 0.02 2.17 0.02 1257
18.725 1.19 0.03 3.37 0.03 1839 1.25 0.03 3.42 0.03 1923
18.975 1.70 0.03 5.07 0.03 2620 1.86 0.04 5.28 0.03 2870
19.225 1.61 0.03 6.68 0.03 2484 2.62 0.04 7.90 0.04 4028
19.475 0.56 0.02 7.24 0.02 855 ... ... ... ... 900
19.725 0.13 0.01 7.37 0.01 206 ... ... ... ... 216
19.975 0.03 0.01 7.41 0.00 53 ... ... ... ... 55
20.225 0.01 0.00 7.42 0.00 19 ... ... ... ... 20
105 changes: 105 additions & 0 deletions descqa/data/AGNdata/SDSS/richards_2006_table6.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
# RICHARDS ET AL. 2006_AJ_131_2766
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the QLF validation using Table 6 also planned? Maybe it'll go in a different PR? Please let me know if I'm missing something!

#phi in units of Mpc^-3 mag^-1
#Fill indicates how well column is covered by data
z M_i(z=2) log_phi dlog_phi Fill zbar N_Q N_Q^corr
0.49 -26.25 -7.74 5.48 1 0.59 11 11.6
0.49 -25.95 -7.46 7.55 1 0.58 21 22.2
0.49 -25.65 -7.26 9.47 1 0.58 33 34.8
0.49 -25.35 -7.07 11.90 1 0.55 52 54.9
0.49 -25.05 -6.81 16.01 1 0.56 94 99.3
0.49 -24.75 -6.59 20.52 1 0.58 154 163.0
0.49 -24.45 -6.42 24.94 1 0.57 228 241.0
0.49 -24.15 -6.23 35.98 0 0.54 337 358.2
0.49 -23.85 -6.08 43.96 0 0.51 358 377.2
0.49 -23.55 -5.97 75.48 0 0.45 311 331.3
0.49 -23.25 -5.81 102.81 0 0.41 290 307.2
0.49 -22.95 -6.35 174.24 0 0.41 39 46.9
0.87 -27.45 -8.39 1.81 1 0.95 5 5.3
0.87 -27.15 -7.81 3.53 1 0.95 19 20.0
0.87 -26.85 -7.63 4.36 1 0.95 29 30.5
0.87 -26.55 -7.29 6.48 1 0.94 64 67.4
0.87 -26.25 -6.96 9.38 1 0.91 134 141.2
0.87 -25.95 -6.84 10.84 1 0.92 179 188.5
0.87 -25.65 -6.62 13.87 1 0.92 293 308.6
0.87 -25.35 -6.42 17.57 1 0.93 470 495.1
0.87 -25.05 -6.30 24.49 0 0.89 492 520.0
0.87 -24.75 -6.23 51.36 0 0.78 284 307.6
0.87 -24.45 -6.13 100.79 0 0.73 122 133.7
0.87 -24.15 -5.86 1446.59 0 0.74 9 13.8
1.25 -28.05 -8.15 2.06 1 1.31 12 12.6
1.25 -27.75 -7.86 2.85 1 1.32 23 24.2
1.25 -27.45 -7.76 3.20 1 1.27 29 30.5
1.25 -27.15 -7.36 5.07 1 1.30 73 76.8
1.25 -26.85 -7.08 7.00 1 1.30 139 146.3
1.25 -26.55 -6.83 9.37 1 1.29 249 262.1
1.25 -26.25 -6.58 12.44 1 1.29 439 462.1
1.25 -25.95 -6.33 16.62 1 1.28 783 824.2
1.25 -25.65 -6.24 22.56 0 1.23 733 773.5
1.25 -25.35 -6.12 48.01 0 1.13 360 382.8
1.25 -25.05 -5.74 1332.39 0 1.09 12 14.6
1.63 -28.65 -8.25 1.70 1 1.66 11 11.6
1.63 -28.35 -8.08 2.06 1 1.67 16 16.8
1.63 -28.05 -7.78 2.91 1 1.68 32 33.7
1.63 -27.75 -7.39 4.57 1 1.66 79 83.2
1.63 -27.45 -7.12 6.23 1 1.67 147 154.7
1.63 -27.15 -6.86 8.43 1 1.66 269 283.2
1.63 -26.85 -6.63 10.94 1 1.65 453 476.8
1.63 -26.55 -6.40 14.35 1 1.66 779 820.0
1.63 -26.25 -6.26 19.09 0 1.62 892 940.9
1.63 -25.95 -6.14 38.86 0 1.52 477 506.0
2.01 -28.95 -8.41 1.37 1 1.99 8 8.4
2.01 -28.65 -7.94 2.37 1 2.02 24 25.3
2.01 -28.35 -7.75 2.94 1 2.02 37 39.0
2.01 -28.05 -7.37 4.53 1 2.01 88 92.7
2.01 -27.75 -7.15 5.86 1 2.03 147 155.0
2.01 -27.45 -6.87 8.03 1 2.02 276 291.0
2.01 -27.15 -6.67 10.22 1 2.01 447 471.1
2.01 -26.85 -6.45 13.97 0 1.99 648 682.7
2.01 -26.55 -6.24 40.12 0 1.90 430 464.3
2.01 -26.25 -6.03 495.10 0 1.87 30 39.4
2.40 -28.95 -8.12 2.07 1 2.44 14 17.9
2.40 -28.65 -8.03 2.30 1 2.41 17 21.8
2.40 -28.35 -7.59 3.71 1 2.37 48 59.7
2.40 -28.05 -7.29 5.28 1 2.37 98 121.2
2.40 -27.75 -7.05 7.01 1 2.37 164 208.1
2.40 -27.45 -6.82 9.50 0 2.38 265 356.0
2.40 -27.15 -6.61 22.11 0 2.30 246 309.0
2.40 -26.85 -6.24 249.51 0 2.25 37 48.8
2.80 -29.55 -8.57 1.76 1 2.70 3 6.2
2.80 -29.25 -8.34 1.84 1 2.82 7 10.6
2.80 -28.95 -8.08 6.51 1 2.82 10 19.2
2.80 -28.65 -7.95 3.68 1 2.80 12 25.9
2.80 -28.35 -7.65 11.94 1 2.83 24 51.5
2.80 -28.05 -7.33 15.75 1 2.81 50 107.9
2.80 -27.75 -7.11 20.63 1 2.82 75 180.9
2.80 -27.45 -7.07 24.17 1 2.79 73 199.8
3.25 -29.55 -8.54 1.10 1 3.35 7 8.2
3.25 -29.25 -8.30 1.45 1 3.25 12 14.2
3.25 -28.95 -8.33 1.40 1 3.20 11 13.1
3.25 -28.65 -7.94 2.18 1 3.25 28 32.5
3.25 -28.35 -7.64 3.12 1 3.23 54 64.6
3.25 -28.05 -7.47 3.89 1 3.25 77 95.9
3.25 -27.75 -7.32 4.72 1 3.24 103 134.3
3.25 -27.45 -7.09 6.47 1 3.21 161 228.8
3.25 -27.15 -6.99 7.48 1 3.22 191 287.9
3.25 -26.85 -6.80 10.40 0 3.20 234 377.5
3.25 -26.55 -6.63 39.58 0 3.11 52 103.7
3.75 -28.95 -8.24 1.56 1 3.69 14 15.7
3.75 -28.65 -8.02 2.03 1 3.67 22 25.7
3.75 -28.35 -7.65 3.06 1 3.77 54 60.5
3.75 -28.05 -7.64 3.11 1 3.76 55 62.1
3.75 -27.75 -7.44 4.07 1 3.74 83 99.3
3.75 -27.45 -7.27 4.96 1 3.76 119 144.2
3.75 -27.15 -7.16 6.59 0 3.72 117 158.4
3.75 -26.85 -6.89 25.48 0 3.59 27 54.6
4.25 -29.25 -8.48 1.16 1 4.25 8 8.4
4.25 -28.65 -8.18 1.64 1 4.22 16 16.9
4.25 -28.35 -8.11 1.79 1 4.19 19 20.0
4.25 -28.05 -7.91 2.26 1 4.21 30 31.8
4.25 -27.75 -7.81 2.53 1 4.24 38 40.2
4.25 -27.45 -7.59 3.84 0 4.16 44 47.1
4.75 -28.65 -8.52 1.14 1 4.66 7 7.4
4.75 -28.35 -8.46 1.22 1 4.71 8 8.4
4.75 -28.05 -8.00 2.07 1 4.66 23 24.2
4.75 -27.75 -8.06 1.94 0 4.66 20 21.1
4.75 -27.45 -7.78 20.57 0 4.62 6 8.3