Add jackknife errors to angular correlation function; add some cosmet… #180
Conversation
|
Here is the descqa test: 2pt correlation fucntion |
|
@yymao Code passed checks and is ready for review |
|
The change here is substantial that I am not comfortable doing a quick review. I wonder if @patricialarsen can help review this one? |
|
@yymao @patricialarsen The code was pulled from the number-density test (so the code is essentially already reviewed) and was run with both cosmoDC2_v1.1.4_image and cosmoDC2_v1.1.4_small to check that the errors looked sensible. This code was also used for the figure in the cosmoDC2 paper. We vetted it at the time, so I expect that the review will be straightforward. |
descqa/CorrelationsTwoPoint.py
Outdated
| @@ -492,7 +498,8 @@ def run_on_single_catalog(self, catalog_instance, catalog_name, output_dir): | |||
| catalog_data, sample_conditions) | |||
|
|
|||
| with open(os.path.join(output_dir, 'galaxy_count.dat'), 'a') as f: | |||
| f.write('{} {}\n'.format(sample_name, len(tmp_catalog_data['ra']))) | |||
| f.write('{} {} {:.1f} sq. deg.\n'.format(sample_name, len(tmp_catalog_data['ra']), | |||
| self.check_footprint(tmp_catalog_data))) #print area | |||
There was a problem hiding this comment.
The footprint is actually calculated on the full set, not the tmp_catalog_data subsamples, so this output is a little misleading
There was a problem hiding this comment.
Changed message to read "Total... area"
descqa/CorrelationsTwoPoint.py
Outdated
| for nj in range(N_jack): | ||
| catalog_data_jk = dict(zip(catalog_data.keys(), [v[(jack_labels != nj)] for v in catalog_data.values()])) | ||
| rand_cat, rr = self.generate_processed_randoms(catalog_data_jk) #get randoms for this footprint | ||
| #print('nj = {}, area = {:.2f}'.format(nj, self.check_footprint(catalog_data_jk))) #check footprint |
There was a problem hiding this comment.
commented out print statement, perhaps this should be deleted?
|
@patricialarsen Committed a new version that addresses your comments. Added note to galaxy counts printout with caveats regarding area calculation. See here. Also removed extra printout and changed printout of area to say Total area. |
|
@patricialarsen Thanks for your review! I think I addressed everything. Let me know if there is anything else. |
Update to include jack-knife errors in w(theta) and to provide some cosmetic options for plotting.
Will post link to test when nersc is back up.