Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revised code for size-distribution test #182

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Revised code for size-distribution test #182

merged 1 commit into from
Sep 18, 2019

Conversation

evevkovacs
Copy link
Contributor

Update to size test, supersedes PR #95
Revised size tests including cosmetic improvements and some corrections to the plots: Example tests

yymao
yymao approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evevkovacs. This looks good to me. I do have one question --- you mentioned that this PR supersedes #95. Do you mean that this one replaces #95 and we should just close #95? Does this PR close #13?

@evevkovacs evevkovacs merged commit dad45d1 into master Sep 18, 2019
@evevkovacs
Copy link
Contributor Author

evevkovacs commented Sep 18, 2019 •
edited
Loading

Thanks @yymao. Yes, this PR replaces #95, which replaced #13. So both of those can be closed along with this one. Would you like me to delete this branch?

This was referenced Sep 18, 2019
Closed
Closed
@yymao yymao deleted the update_size branch April 11, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yymao yymao yymao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evevkovacs @yymao