Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic changes for nicer figures #185

Merged
merged 10 commits into from
Sep 30, 2019
Merged

Cosmetic changes for nicer figures #185

merged 10 commits into from
Sep 30, 2019

Conversation

evevkovacs
Copy link
Contributor

If you are submitting a PR for a validation test (either adding a new one or updating an existing one), please post a link to the DESCQA web interface for the test you are submitting.
Added some cosmetic changes to allow for making better figures. See [here] (https://portal.nersc.gov/project/lsst/descqa/v2/?run=2019-09-19_4) for a test run.

descqa/apparent_mag_func_test.py Outdated Show resolved Hide resolved
descqa/apparent_mag_func_test.py Outdated Show resolved Hide resolved
descqa/apparent_mag_func_test.py Outdated Show resolved Hide resolved
descqa/apparent_mag_func_test.py Outdated Show resolved Hide resolved
descqa/apparent_mag_func_test.py Outdated Show resolved Hide resolved
@evevkovacs
Copy link
Contributor Author

@yymao See test result for example of code with object catalog. Other issues should be fixed.

@evevkovacs
Copy link
Contributor Author

@yymao Just caught your last comments. The commented line has been removed. I also removed the exception clause. I have already checked that the catalog has ra and dec so there is no reason for the call to get_sky_area to fail, and it is safe to remove the exception.

Copy link
Member

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evevkovacs thanks! I would then suggest that we reorganize the logic a little bit for lines 152-165. In particular, checking ra/dec existence is more relevant for sky area, not for light cone. See my inline suggestion.

descqa/apparent_mag_func_test.py Show resolved Hide resolved
Copy link
Member

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@evevkovacs evevkovacs merged commit 1772458 into master Sep 30, 2019
@evevkovacs evevkovacs deleted the dndmag branch September 30, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants