Cosmetic updates; changes to include snapshot catalogs and lsst magni… #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yymao
requested changes
Sep 21, 2019
There was a problem hiding this comment.
@evevkovacs thanks. there are some minor issues to address.
descqa/ColorDistribution.py
Outdated
| '{} < {}'.format(labels['redshift'], self.zhi)] | ||
| else: | ||
| filters = None | ||
| self.redshift = catalog_instance.redshift |
There was a problem hiding this comment.
This may cause unintended effect because the instance of the test class will be reused for all catalogs.
Suggested change
| self.redshift = catalog_instance.redshift | |
| self.redshift = catalog_instance.redshift |
There was a problem hiding this comment.
@yymao Not sure what you were suggesting here, but I realized that I didn't need redshift to be a class variable. It is now local. This will fix the travis issue. Let me know if it doesn't address your concern.
descqa/ColorDistribution.py
Outdated
| @@ -33,7 +34,16 @@ | |||
| color_transformation['sdss2cfht']['r'] = 'r - 0.024 * (g - r)' | |||
| color_transformation['sdss2cfht']['i'] = 'i - 0.085 * (r - i)' | |||
| color_transformation['sdss2cfht']['z'] = 'z + 0.074 * (i - z)' | |||
|
|
|||
| color_transformation['lsst2cfht']['u'] = 'u' | |||
There was a problem hiding this comment.
Are Lines 37 to 46 really needed? If no transformation is needed, it should not appear here I think...
There was a problem hiding this comment.
Oops yes, that was left in by mistake.
|
@yymao OK, travis checks passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tudes