Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added emission line QA test and SDSS comparison data set. #187

Merged
merged 12 commits into from
Nov 20, 2019

Conversation

adam-broussard
Copy link
Contributor

Copy link
Contributor

@evevkovacs evevkovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a summary file for cuts (already done) and bigger fonts for the axes.
The text box for p values etc. should appear on the cosmoDC2 panel, since they are relevant for the catalog being validated. What does D=.28 mean? Why are there 2 numbers for the median shift?
Please post a link to the updated plot once the comments are addressed.

@adam-broussard
Copy link
Contributor Author

Requested changes have been implemented. D has been renamed to D_{KS} to make it more readily apparent that it is the maximum distance in the cumulative distribution functions, which is then mapped to a probability value p. The two numbers for the median shift indicate shift in the x- and y-directions. Is there a better way I could indicate that without making the text too long?

Updated Web Interface Link

@evevkovacs evevkovacs merged commit 402625d into LSSTDESC:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants