Move CI test to GitHub action #188
Conversation
There was a problem hiding this comment.
I don't understand the details in .github/workflows/pythonpackage.yml, but otherwise the structure makes sense. I think it would be very helpful to add some comments to indicate how to modify the file in case someone (other than Yao) needs to make changes. For example, if an additional library besides libgfortran needs to be installed, do we just duplicate that section for the new library? Alternatively give a pointer to instructions for how to maintain this file. Another question is what if additional python imports are required. Is that still handled in the setup.py?
The other changes are fine.
|
@evevkovacs thanks for the feedback, I've added an "Integration test" section to See if that works. |
|
@yymao Thanks, you can merge, or let me know if you would like me to go ahead with it. |
This PR moves the current travis-CI test to GitHub action because it runs faster, integrates with GitHub better, and has a cleaner output (so that it is easier to see what need to be fixed).
With this PR I also fix a few existing linting issues.