Units fixes for EmissionlineRatioTest #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evevkovacs
approved these changes
Nov 21, 2019
adam-broussard
added a commit
to adam-broussard/descqa
that referenced
this pull request
Nov 22, 2019
* Removed lines of code that converted to cgs units and fluxes nedlessly * Fixed simulation subsampling * Removed unused variables * Removed unneeded variables containing redshift and galaxy ID from catalog * Moved plotting to after drawing SDSS galaxies so that plots accurately reflect compared distributions * Fixed data filepath to make it more flexible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes to validation test content, but I have simplified the code so that it no longer converts emission line luminosities to fluxes before performing the test.