Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added config to filter for halo_id #208

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Added config to filter for halo_id #208

merged 1 commit into from
Dec 5, 2020

Conversation

fjaviersanchez
Copy link
Contributor

Added configuration file for mock specific bias_test (selects objects with positive halo_id) and modified name of previous test (which will work with object catalogs with redshift and mocks but may include unclustered objects).

evevkovacs
evevkovacs approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@evevkovacs evevkovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. I think the maximum limit on halo_id is fine for the forseeable future because we won't get a catalog that is larger than the number you give in the configuration file.

@fjaviersanchez
Copy link
Contributor Author

Thank you! Should I merge?

@evevkovacs evevkovacs merged commit a3e5849 into LSSTDESC:master Dec 5, 2020
@evevkovacs
Copy link
Contributor

Thanks I just merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evevkovacs evevkovacs evevkovacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fjaviersanchez @evevkovacs