Add printout of data points; improve titles and labels #211
Conversation
evevkovacs
commented
Dec 7, 2020
evevkovacs
commented
There was a problem hiding this comment.
Thanks @evevkovacs --- I have some change requests that I commented inline.
| @@ -206,26 +211,26 @@ def get_catalog_data(gc, quantities, filters=None): | |||
|
|
|||
| # define theory from within this class | |||
|
|
|||
| def post_process_plot(self, ax): | |||
| def post_process_plot(self, ax, fig): | |||
There was a problem hiding this comment.
To maintain compatibility with other calls of this function..
| def post_process_plot(self, ax, fig): | |
| def post_process_plot(self, ax, fig=None): |
There was a problem hiding this comment.
I already caught this one myself and fixed it.
|
|
||
| fig.subplots_adjust(hspace=0) |
There was a problem hiding this comment.
To maintain compatibility with other calls of this function..
| fig.subplots_adjust(hspace=0) | |
| if fig is not None: | |
| fig.subplots_adjust(hspace=0) |
There was a problem hiding this comment.
fig should have been in the call to the function. I just forgot it.
descqa/shear_test.py
Outdated
| ''' | ||
| Post-processing routines on plot | ||
| ''' | ||
| zmeans = np.linspace(self.zlo, self.zhi, self.ntomo+2)[1:-1] | ||
| #zmeans = np.linspace(self.zlo, self.zhi, self.ntomo+2)[1:-1] |
There was a problem hiding this comment.
Remove unused code instead of just commenting it out. If it must be kept, provide a reason inline.
| #zmeans = np.linspace(self.zlo, self.zhi, self.ntomo+2)[1:-1] |
descqa/shear_test.py
Outdated
| @@ -50,8 +50,11 @@ def __init__(self, | |||
| **kwargs): | |||
| #pylint: disable=W0231 | |||
|
|
|||
| plt.rcParams['font.size'] = 9 | |||
|
|
|||
| #plt.rcParams['font.size'] = 9 | |||
There was a problem hiding this comment.
Remove unused code instead of just commenting it out. If it must be kept, provide a reason inline.
| #plt.rcParams['font.size'] = 9 |
|
@yymao The changes are pushed. Sorry I should have checked and cleaned up the code before requesting your review. |
