Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source DESC setup script directly in run_master.sh #213

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Source DESC setup script directly in run_master.sh #213

merged 2 commits into from
Dec 15, 2020

Conversation

yymao
Copy link
Member

@yymao yymao commented Dec 7, 2020

OK, let's directly source DESC setup script directly in run_master.sh to avoid more troubles 馃檪

@yymao yymao requested a review from heather999 December 7, 2020 18:33
@yymao yymao linked an issue Dec 7, 2020 that may be closed by this pull request
Set HDF5_USE_FILE_LOCKING=FALSE in run_master.sh #212
Closed
@yymao yymao mentioned this pull request Dec 11, 2020
Closed
9 tasks
@yymao
Copy link
Member Author

yymao commented Dec 12, 2020

Tested. Merging now.

@yymao
Copy link
Member Author

yymao commented Dec 12, 2020

Actually, need someone reviews it..

evevkovacs
evevkovacs approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@evevkovacs evevkovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yymao
Copy link
Member Author

yymao commented Dec 15, 2020

Thanks @evevkovacs

@yymao yymao merged commit eb5461f into master Dec 15, 2020
@yymao yymao deleted the issues/212/use-desc-setup-file branch December 15, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evevkovacs evevkovacs evevkovacs approved these changes

@heather999 heather999 Awaiting requested review from heather999

Assignees
No one assigned
Labels
execution script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set HDF5_USE_FILE_LOCKING=FALSE in run_master.sh
2 participants
@yymao @evevkovacs