Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paper figs #223

Merged
merged 6 commits into from
Jun 17, 2021
Merged

Paper figs #223

merged 6 commits into from
Jun 17, 2021

Conversation

evevkovacs
Copy link
Contributor

If you are submitting a PR for a validation test (either adding a new one or updating an existing one), please post a link to the DESCQA web interface for the test you are submitting.
Many minor updates to configuration files and tests to accommodate changes for the validation paper. Added 2 new data sets for the color-redshift test and the galaxy bias test.

yymao
yymao reviewed Jun 9, 2021
View reviewed changes
Copy link
Member

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing unused variables

descqa/ColorRedshiftTest.py Outdated Show resolved Hide resolved
descqa/ColorRedshiftTest.py Outdated Show resolved Hide resolved
descqa/BiasVersusRedshift.py Outdated Show resolved Hide resolved
descqa/BiasVersusRedshift.py Outdated Show resolved Hide resolved
@evevkovacs
Copy link
Contributor Author

@yymao The remaining changes are all minor changes to config files. I also saved all the config files that I used to run the figures for the paper, which I think is worthwhile doing. I asked you to review. Thanks

@evevkovacs evevkovacs requested a review from yymao June 9, 2021 15:29
yymao
yymao approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@yymao yymao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evevkovacs evevkovacs merged commit 846b38e into master Jun 17, 2021
@evevkovacs evevkovacs deleted the paper_figs branch June 17, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yymao yymao yymao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evevkovacs @yymao