Added tested bias validation test #87
Conversation
|
@morriscb has updated the code structure of the tcpf test (see #91) and I am thinking we can probably incorporate this bias test and also #73 into the new structure. What do you think, @fjaviersanchez @vvinuv? I will explore this path this week. |
|
@yymao I think it is nice idea. @evevkovacs just send me message to measure the 2pt correlation from the catalogs |
|
You should be able to spawn new tests against correlation function measurements by inheriting one of the Correlations classes and overwriting the score_and_test method of the class. You can do something similar with the plotting method. If you want an example you can look at https://github.com/LSSTDESC/descqa/pull/91 and check out the DEEP2StellarMassTwoPoint class as an example of doing this. |
|
@morriscb thanks! I'll give it a try! |
|
@yymao are you working on this?
…On 26 March 2018 at 17:48, Yao-Yuan Mao ***@***.***> wrote:
@morriscb <https://github.com/morriscb> thanks! I'll give it a try!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#87 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADJ23XCWTxvZhiC9PRaW_nDanVbpSi0wks5tiXAogaJpZM4SZXau>
.
--
Vinu Vikraman
http://www.hep.anl.gov/vvikraman/ <http://www.sas.upenn.edu/~vinu/>
|
|
@vvinuv I'm about to. Do you want me to wait? |
|
@yymao I will do it tonight if you won't start by that time.
…On 27 March 2018 at 13:24, Yao-Yuan Mao ***@***.***> wrote:
@vvinuv <https://github.com/vvinuv> I'm about to. Do you want me to wait?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#87 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADJ23aOUAW4oxENdbtqTb94TO0ZPkud9ks5tioPogaJpZM4SZXau>
.
--
Vinu Vikraman
http://www.hep.anl.gov/vvikraman/ <http://www.sas.upenn.edu/~vinu/>
|
|
@yymao is there anything I can do to finish this PR? :) |
|
@fjaviersanchez Could you please summarize the current status? Has the test incorporated the code developed by Chris Morrison (as suggested above)? |
|
@evevkovacs not that I am aware of. Should I add that? It needs also a validation criteria that I think we decided to go with just to be an increasing function with redshift. |
|
@fjaviersanchez I think it makes sense to re-use the existing code for computing the correlation functions. It has been vetted and tested by several people. |
|
Yes, I was using TreeCorr with @vvinuv's code. I'll switch to Chris'. Thanks! |
|
@fjaviersanchez @yymao Has there been any further progress on this test? I gather that one issue is obtaining a theory prediction. Could we do something interim like generate a data file containing the theory prediction for the protoDC2 cosmology and use that? How close are we to having the test incorporated into DESCQA? Thanks. |
|
@evevkovacs, Sorry for the delay! I started to change this last weekend to use Chris' code but I haven't been able to make it run properly. Yes, one issue is generating the theoretical prediction and that would require including CCL as a dependency. The approach that you suggest can be valid but then, we either have one set of redshift bins/redshift distributions that are valid or perform the integration of the power-spectra ourselves. |
|
@fjaviersanchez How about doing the simplest thing for now and fixing the redshift bins? |
|
In any case, CCL should be installed in the shared DESC Python environment. Let me check with Heather. |
|
@yymao I updated the scripts but I don't get good results for the bias for |
|
@fjaviersanchez thanks for the update. I'm looking into this... |
descqa/BiasVersusRedshift.py
Outdated
| nz_data[sample_name] = (zcent, nz*1.0) | ||
|
|
||
| # Generate CCL tracer object to compute Cls -> w(theta) | ||
| tracer = ccl.ClTracerNumberCounts(cosmo, has_rsd=False, has_magnification=False, |
There was a problem hiding this comment.
ccl.ClTracerNumberCounts is no longer available in CCL.
There was a problem hiding this comment.
Thanks @yymao! I'll update this tomorrow.
|
Alright, I updated the script to be able to run with the latest version of CCL. An example of the results can be found here: https://portal.nersc.gov/cfs/lsst/descqa/v2/?run=2020-12-02_5&test=bias_test |
|
@fjaviersanchez Can I try to run this on cosmoDC2? Will it work? Thanks |
|
It runs. Results are here: https://portal.nersc.gov/cfs/lsst/descqa/v2/?run=2020-12-02_10 (Note the the bias values are pretty small. I think this is due to the super low mass galaxies that were added later on?) |
|
OK, thanks. We can test this hypothesis by cutting those out. All you have to do is to filter on halo_id being positive. The ultra-faint galaxies all have negative halo_id's. |
Validation test to compute galaxy bias in tomographic bins. I couldn't post the web interface because it needs CCL (currently not installed at the NERSC DESCQA shared install). I am attaching one plot for buzzard_test.
The points are the measured correlation function and the lines are the theoretical prediction using the best fit bias and the input cosmological parameters (except for s8 and n_s since they are not in the cosmology astropy class).
Caveats: Fixed sigma8 and scalar index. Correlation function only. No validation criteria so far.
[Edited by @yymao: This PR fixes #75]