Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SN+BAO+CMB examples #188

Merged
merged 6 commits into from
Oct 12, 2022
Merged

Added SN+BAO+CMB examples #188

merged 6 commits into from
Oct 12, 2022

Conversation

am610
Copy link
Member

@am610 am610 commented Oct 9, 2022

Added ini file demonstrating how SN+BAO+CMB chains can be produced.

marcpaterno
marcpaterno requested changes Oct 10, 2022
View reviewed changes
examples/srd_sn/sn_srd_planck_bao.ini Outdated

[default]
fatal_errors = T
planck_path = ${CSL_DIR}/likelihood/planck2018/baseline/plc_3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

planck_path is usually used to set paths to the Planck data, as specified elsewhere in the file. I don't see it used -- is that an oversight, or is the planck_path parameter not needed?

marcpaterno
marcpaterno requested changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@marcpaterno marcpaterno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I'm interpreting the GitHub web interface correctly, but you may have accidentally committed a file #generate_sn_data.py# (perhaps an editor backup file)?

Please check this, and if it is correct, remove the file from the pull request. If it is not correct,, please post a follow-up comment saying this is the case.

@am610
Copy link
Member Author

am610 commented Oct 12, 2022

I am not sure I'm interpreting the GitHub web interface correctly, but you may have accidentally committed a file #generate_sn_data.py# (perhaps an editor backup file)?

Please check this, and if it is correct, remove the file from the pull request. If it is not correct,, please post a follow-up comment saying this is the case.

Please check, I think the #generate_sn_data.py# file is successfully removed now.

@marcpaterno marcpaterno merged commit 2921428 into LSSTDESC:master Oct 12, 2022
@am610 am610 deleted the SN_newbranch-1 branch October 12, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcpaterno marcpaterno marcpaterno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@am610 @marcpaterno