Ellipticity, position angle correction in protodc2 GCR. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed Sersic index into the morphology group.
…g versions supported are explicitly
yymao
requested changes
Dec 8, 2017
GCRCatalogs/alphaq.py
Outdated
| @@ -65,7 +66,9 @@ def _subclass_init(self, filename, **kwargs): | |||
| 'size_bulge_true': 'morphology/spheroidHalfLightRadius', | |||
| 'disk_sersic_index': 'morphology/diskSersicIndex', | |||
| 'bulge_sersic_index': 'morphology/spheroidSersicIndex', | |||
| 'ellipticity_1': 'morphology/totalEllipticity1', | |||
| 'position_angle': (lambda pos_angle: pos_angle*(180.0/np.pi)**2,'morphology/positionAngle'), | |||
There was a problem hiding this comment.
- Please confirm if
**2in this formula is correct - use
np.rad2deginstead of*(180.0/np.pi) - Please add one space after comma
There was a problem hiding this comment.
I incorrectly converted the units, so I have apply the conversion twice. The position angle comes out 0->180. I can apply the function twice...
GCRCatalogs/alphaq.py
Outdated
| @@ -65,7 +66,9 @@ def _subclass_init(self, filename, **kwargs): | |||
| 'size_bulge_true': 'morphology/spheroidHalfLightRadius', | |||
| 'disk_sersic_index': 'morphology/diskSersicIndex', | |||
| 'bulge_sersic_index': 'morphology/spheroidSersicIndex', | |||
| 'ellipticity_1': 'morphology/totalEllipticity1', | |||
| 'position_angle': (lambda pos_angle: pos_angle*(180.0/np.pi)**2,'morphology/positionAngle'), | |||
| 'ellipticity_1': (lambda ellip2, pos_angle : ellip2/np.tan(2*pos_angle*(180.0/np.pi)) , 'morphology/totalEllipticity2','morphology/positionAngle'), | |||
There was a problem hiding this comment.
- use
np.rad2deginstead of*(180.0/np.pi) - Please add one space after commas, and remove spaces before commas
- Please remove the space before colon
GCRCatalogs/alphaq.py
Outdated
| 'ellipticity_1': 'morphology/totalEllipticity1', | ||
| 'position_angle': (lambda pos_angle: pos_angle*(180.0/np.pi)**2,'morphology/positionAngle'), | ||
| 'ellipticity_1': (lambda ellip2, pos_angle : ellip2/np.tan(2*pos_angle*(180.0/np.pi)) , 'morphology/totalEllipticity2','morphology/positionAngle'), | ||
| 'size_true': (lambda size1,size2,lum1,lum2: ((size1*lum1)+(size2*lum2))/(lum1+lum2),'morphology/diskHalfLightRadius','morphology/spheroidHalfLightRadius','LSST_filters/diskLuminositiesStellar:LSST_r:rest','LSST_filters/spheroidLuminositiesStellar:LSST_r:rest'), |
GCRCatalogs/alphaq.py
Outdated
| @@ -12,6 +12,7 @@ | |||
| __all__ = ['AlphaQGalaxyCatalog'] | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Add a line __version__ = '2.1.1.1' (or your preferred versioning scheme) to indicate the version of this reader file.
GCRCatalogs/alphaq.py
Outdated
| @@ -74,7 +77,7 @@ def _subclass_init(self, filename, **kwargs): | |||
| 'velocity_y': 'vy', | |||
| 'velocity_z': 'vz', | |||
| } | |||
|
|
|||
yymao
requested changes
Dec 8, 2017
GCRCatalogs/alphaq.py
Outdated
| self.sky_area = fh['metaData/skyArea'].value | ||
| else: | ||
| self.sky_area = 25 #If the sky area isn't specified use the default value of the sky area. | ||
|
|
There was a problem hiding this comment.
add self.sky_area = float(self.sky_area) to ensure it is a float
yymao
approved these changes
Dec 8, 2017
This was referenced Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.