-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dc2_object_run2.2i_dr6_v2_with_addons #595
Conversation
In aefba29
|
In 812e6f8,
|
I haven't tried to load these, but overall the changes and additions look reasonable. I have a question about the update to dc2_truth_run2.2i_summary_tract_partition.yaml. Base directory is ..truth/tract_partition/raw, which includes rather large parquet files. The suggestion is to use dc2_run2.2i_truth_merged_summary instead. That points to the new, much smaller summary files. Is that because the files in tract_partition/raw include all the columns from galaxy truth? But we don't expect people to actually be referencing those extra columns? |
Checking the size:
Neither of these includes all the columns from galaxy truth. I think the difference mainly come from (1) the smaller footprint of the star truth catalog and (2) the small total number of columns (mostly from removing |
I was comparing only individual files; I think 2) is the reason for the difference I saw. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems fine.
In this PR:
dc2_object_run2.2i_dr6_v2_with_addons
was renamed todc2_object_run2.2i_dr6_v2_with_addons_v1
dc2_object_run2.2i_dr6_v2_with_addons_v2
was created with the new truth match addondc2_object_run2.2i_dr6_v2_with_addons
was changed to an alias config, currently still pointing todc2_object_run2.2i_dr6_v2_with_addons_v1
so that it doesn't break anyone's one. A deprecation message was added to encourage users to update todc2_object_run2.2i_dr6_v2_with_addons_v2
.Thanks @johannct for suggestion.