Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point desc_dc2_run2.2i_dr6_v4_object to v4 directory #605

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

yymao
Copy link
Member

@yymao yymao commented Oct 27, 2022

As reported #604, desc_dc2_run2.2i_dr6_v4_object was an alias of desc_dc2_run2.2i_dr6_v2_object. Indeed these two catalogs are identical; however, for public users, if they downloaded the v4 object catalogs, the newly downloaded files will be stored in a directory with v4 in its path, not v2. As a result, desc_dc2_run2.2i_dr6_v4_object cannot be set as an alias.

@yymao yymao linked an issue Oct 27, 2022 that may be closed by this pull request
@JoanneBogart
Copy link
Contributor

Just to be sure I understand - the issue is that the downloading of, e.g., v4, is done by physical directory, so the file being aliased to would not be downloaded. Is that it?

@yymao
Copy link
Member Author

yymao commented Oct 27, 2022

The physical files are not aliased and will be downloaded from the portal, but the downloaded files will be stored under ^/lsstdesc-public/dc2/run2.2i-dr6-v4/object_dpdd (notice the v4 in the path).

The original config uses alias so its path will be the same as v2, but in reality the path needs to has v4, and that's the issue here.

I just made another commit to switch to based_on, which allows us to use the v2 config but just update the path.

Copy link
Contributor

@JoanneBogart JoanneBogart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yymao yymao merged commit 592657b into master Oct 27, 2022
@yymao yymao deleted the issues/604/public-object-v4 branch October 27, 2022 16:19
@yymao yymao mentioned this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

desc_dc2_run2.2i_dr6_v4_object pointing to v2 directory
2 participants