a cleaner way of applying the obs_lsst xtalk coefficients

LSSTDESC · Nov 22, 2018 · 3df13ba · 3df13ba
1 parent d9a8ec2
commit 3df13ba
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/python/desc/imsim/camera_readout.py b/python/desc/imsim/camera_readout.py
@@ -349,12 +349,11 @@ def _apply_crosstalk(self):
         amp_names = self.camera_info.get_amp_names(self.sensor_id)
         imarrs = np.array([self.amp_images[amp_name].getArray()
                            for amp_name in amp_names])
-        for amp_index, amp_name, row in zip(range(len(amp_names)),
-                                            amp_names, xtalk):
-            xtalk_row = list(row)
-            xtalk_row[amp_index] = 1.
+        for amp_index, amp_name, xtalk_row in zip(range(len(amp_names)),
+                                                  amp_names, xtalk):
             self.amp_images[amp_name].getArray()[:, :] \
-                = sum([x*y for x, y in zip(imarrs, xtalk_row)])
+                = (imarrs[amp_index] +
+                   sum([x*y for x, y in zip(imarrs, xtalk_row)]))
 
     def get_amplifier_hdu(self, amp_name, compress=True):
         """