Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treering flats #126

Closed
wants to merge 10 commits into from
Closed

treering flats #126

wants to merge 10 commits into from

Conversation

hsnee
Copy link
Member

@hsnee hsnee commented Jul 30, 2018

this should resolve #120

@coveralls
Copy link

coveralls commented Jul 30, 2018

Coverage Status

Coverage decreased (-0.2%) to 70.379% when pulling 8a21672 on u/hsnee/treering_flats into e311a5f on master.

@jchiang87
Copy link
Collaborator

Thanks for this Husni. I'll do a more complete review in the next day or so, but I wanted to suggest now that it would be better to make a standalone make_flats.py script rather than adding this functionality to imsim.py. So I would request that you revert the changes to imsim.py and add a make_flats.py script to the bin.src folder.

@cwwalter
Copy link
Member

This was completed in #132.

@cwwalter cwwalter closed this Aug 24, 2018
@rmjarvis rmjarvis deleted the u/hsnee/treering_flats branch September 8, 2021 15:51
@rmjarvis rmjarvis restored the u/hsnee/treering_flats branch September 8, 2021 15:51
@rmjarvis rmjarvis deleted the u/hsnee/treering_flats branch September 8, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a flat-production script
4 participants