Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header fixes and LSSTCamSim support #473

Merged
merged 11 commits into from
May 23, 2024
Merged

Header fixes and LSSTCamSim support #473

merged 11 commits into from
May 23, 2024

Conversation

jchiang87
Copy link
Collaborator

No description provided.

@jchiang87 jchiang87 marked this pull request as ready for review May 17, 2024 17:39
@jchiang87 jchiang87 requested a review from cwwalter May 17, 2024 17:39
Copy link
Member

@jmeyers314 jmeyers314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

telcode = 'MC'
dayobs = eimage.header['DAYOBS']
seqnum = eimage.header['SEQNUM']
contrllr = eimage.header['CONTRLLR']
phdu.header['TELESCOP'] = SIMONYI_TELESCOPE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe factor out some of the other common keywords too? E.g., 'RAFTBAY', 'CCDSLOT', 'RA', 'DEC', 'ROTCOORD', 'ROTPA', ...?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to do that more cleanly, I'd like to get rid of support for LsstCamImSim, otherwise I suspect the number of if statements will actually increase. In fact, in addition to getting rid of LsstCamImSim support, I'd like to support just *Sim cameras explicitly, e.g., LsstCamSim and LsstComCamSim, so also removing LsstCam as an option. I'll post an issue with this proposal.

if eimage.header['IMGTYPE'] == 'SKYEXP':
phdu.header['RADESYS'] = 'ICRS'
phdu.header['TRACKSYS'] = 'RADEC'
else:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does this get used? Simulated flats?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(by this, I mean TRACKSYS = LOCAL).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for anything not on-sky, specifically any calibration frames.

@jchiang87 jchiang87 merged commit d580f71 into main May 23, 2024
3 checks passed
@jchiang87 jchiang87 deleted the u/jchiang/header_fixes branch May 23, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants