CI skyCatalogs install fix + doc fixes #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
esheldon
commented
May 22, 2024
esheldon
commented
- Indicate setting IMSIM_HOME for conda install
- modify pip install for skyCatalogs. --no-build-isolation is needed for newer pip. See Issue on install skyCatalogs#101
|
the CI failure here is the same failure fixed by the indication in the docs. I'll push a change to the CI fixing this |
this is exactly what the new docs indicate
these lines worked for a different project with a skyCatalogs dependency
|
I checked and today this also fails for my other repo. What worked yesterday does not work today, maybe due to a change in the setuptools used in CI |
|
With help from @beckermr it seems this is due to another change showing up today, setuptools moving to version 70. |
|
Bug found, in pyproject.yaml the line should be changed There is an extra "." |
|
I'd like to go ahead and merge this tomorrow morning ~8am PT unless someone objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.