Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing assorted items in issue 51 #106

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

drewoldag
Copy link
Contributor

This PR addresses some of the items listed in issue #51

  • Adding a link to a git cheat sheet.

@drewoldag drewoldag self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36bc641) 100.00% compared to head (87897a6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drewoldag drewoldag linked an issue Oct 27, 2023 that may be closed by this pull request
10 tasks
@drewoldag drewoldag force-pushed the issue/51/updating-onboarding-instructions branch from ab3ce79 to 87897a6 Compare October 27, 2023 22:12
Copy link
Member

@OliviaLynn OliviaLynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this!

@@ -51,6 +51,9 @@ Contribution workflow

The ``rail`` and ``rail_<xxx>`` repositories use an issue-branch-review workflow,
similar to the standard `GitHub Flow <https://docs.github.com/en/get-started/quickstart/github-flow>`_.
We typically use ``git`` as our version control tool, there are many resources
Copy link
Member

@OliviaLynn OliviaLynn Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We typically use ``git`` as our version control tool, there are many resources
We typically use ``git`` as our version control tool. There are many resources

Small grammar nit (this could stay a comma as long as we add a conjunction right after)

@drewoldag drewoldag merged commit 0d0c173 into main Oct 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise dev-oriented onboarding instructions
2 participants