Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move informer superstages to their own module #19

Closed
aimalz opened this issue Jun 29, 2023 · 0 comments
Closed

Move informer superstages to their own module #19

aimalz opened this issue Jun 29, 2023 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@aimalz
Copy link
Collaborator

aimalz commented Jun 29, 2023

This is mostly a heads up about the one aspect of LSSTDESC/rail#37 that touches on this repository, i.e. base code. I'm going to make a new module for the various Informer stage base classes because they're distinguished by taking some forms of data as input and producing a model file as output and are thus shared across algos; an algo with a stage for more than one of estimator/summarizer/classifier will share a single informer stage, yet its superclass will be imported from from just one of the estimator/summarizer/classifier modules. Under this change, new developers would just have one place to look to find the right informer superclass for their algo.

EDIT: Relatedly, src/rail/core/data.py should be renamed src/rail/core/handletypes.py or something like that so it's descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant